Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update dependencies for all modules #7061

Merged
merged 2 commits into from Mar 27, 2024
Merged

Conversation

zasweq
Copy link
Contributor

@zasweq zasweq commented Mar 21, 2024

This PR updates the go.mods of the repository.

RELEASE NOTES: N/A

@zasweq zasweq added this to the 1.64 Release milestone Mar 21, 2024
@zasweq zasweq added the Type: Dependencies Updating/adding/removing dependencies label Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Merging #7061 (9b6ba18) into master (cce1632) will decrease coverage by 0.28%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7061      +/-   ##
==========================================
- Coverage   82.55%   82.27%   -0.28%     
==========================================
  Files         300      300              
  Lines       31351    31351              
==========================================
- Hits        25881    25794      -87     
- Misses       4416     4485      +69     
- Partials     1054     1072      +18     

see 18 files with indirect coverage changes

@dfawley
Copy link
Member

dfawley commented Mar 21, 2024

Why does this also update the protos? Is that going to clash with your recent protoc-gen-go-grpc change?

@dfawley dfawley assigned zasweq and unassigned dfawley Mar 21, 2024
@zasweq
Copy link
Contributor Author

zasweq commented Mar 21, 2024

It broke vet proto by updating. so I regenerated protos. it seems to clash with #7061

@zasweq
Copy link
Contributor Author

zasweq commented Mar 22, 2024

In the PR, the go.mod/go.sum of the cmd/ directory changed. Thus, I needed to regenerate the protos since generated protos would have different syntax (I followed this process from our release doc).

@zasweq zasweq assigned dfawley and unassigned zasweq Mar 22, 2024
@zasweq zasweq changed the title Update go mods deps: update dependencies for all modules Mar 27, 2024
@zasweq zasweq merged commit ba1bf9e into grpc:master Mar 27, 2024
14 checks passed
arvindbr8 pushed a commit to arvindbr8/grpc-go that referenced this pull request Apr 2, 2024
arvindbr8 pushed a commit to arvindbr8/grpc-go that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Dependencies Updating/adding/removing dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants