Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the comment in the server interface #7362

Closed

Conversation

infovivek2020
Copy link
Contributor

Addresses: #7350

Copy link

CLA Missing ID CLA Not Signed

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.50%. Comparing base (6126383) to head (2c77b72).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7362      +/-   ##
==========================================
- Coverage   81.52%   81.50%   -0.02%     
==========================================
  Files         348      348              
  Lines       26754    26754              
==========================================
- Hits        21811    21807       -4     
- Misses       3762     3766       +4     
  Partials     1181     1181              

see 15 files with indirect coverage changes

@purnesh42H
Copy link
Contributor

Since you made a change in protoc gen, you need to regenerate all pb.go files again. Please run the command mentioned here https://github.com/grpc/grpc-go/blob/master/doc.go#L19

@purnesh42H purnesh42H added the P2 label Jul 1, 2024
@purnesh42H purnesh42H added this to the 1.66 Release milestone Jul 1, 2024
@purnesh42H purnesh42H added Type: Bug Type: Documentation Documentation or examples and removed Type: Bug labels Jul 2, 2024
@infovivek2020
Copy link
Contributor Author

infovivek2020 commented Jul 3, 2024

@purnesh42H running go generate ./scripts/regenerate.sh is not generating proto file in local getting "Command 'gopls.generate' failed: Error: exit status 1."

running "./scripts/regenerate.sh": fork/exec ./scripts/regenerate.sh: %1 is not a valid Win32 application.

@purnesh42H
Copy link
Contributor

@infovivek2020 Make sure you have latest go version installed and then follow the below setup

Ensure that you have installed the protoc-gen-go and protoc-gen-go-grpc plugins correctly. Run below commands
go install google.golang.org/protobuf/cmd/protoc-gen-go@latest
go install google.golang.org/grpc/cmd/protoc-gen-go-grpc@latest

After installing the plugins, the binaries will be in the Go bin directory. You need to add this directory to your PATH. Find the Go bin directory, which is typically located at $(go env GOPATH)/bin. Add it to your PATH.
You can do this temporarily in your current terminal session or permanently by modifying your shell profile export PATH="$PATH:$(go env GOPATH)/bin".
To add to your bash profile run
echo 'export PATH="$PATH:$(go env GOPATH)/bin"' >> ~/.bashrc source ~/.bashrc

Regenerate protobuf files
go generate

@purnesh42H purnesh42H removed the P2 label Jul 3, 2024
@purnesh42H
Copy link
Contributor

@infovivek2020 were you able to get the setup working? If you are using windows, you probably have to find equivalent commands for windows or do the setup on a linux VM

@infovivek2020
Copy link
Contributor Author

infovivek2020 commented Jul 4, 2024

@purnesh42H tried in the window but that one still not working same error in my system

@purnesh42H
Copy link
Contributor

@infovivek2020 is it possible for you to generate them in a linux machine. You can do in your personal vm or if any of your colleague has a linux vm setup, you can do there as well

@infovivek2020
Copy link
Contributor Author

#7392
Raised new PR for the same issue so closing

@infovivek2020 infovivek2020 deleted the update-protoc-comment branch July 5, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Documentation or examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants