-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protoc gen adds comment, does not follow godoc. #7350
Comments
@titpetric we can fix this by adding punctuation in protoc generation here https://github.com/grpc/grpc-go/blob/master/cmd/protoc-gen-go-grpc/grpc.go#L267 and then regenerate all pb.go files. Do you want to give a try for fix? |
@titpetric just checking in if you will be doing a fix PR for this |
@infovivek2020 beat me to it :) 🫡✅ |
Assigning to @purnesh42H since @infovivek2020 isn't showing up as an option to set as the assignee. |
@purnesh42H I have raised PR #7392 the please review |
For the service interface a comment is added to the generated interface, as seen on #3794
This appended comment violates godoc as it does not end with punctuation (dot).
Expected:
Is there a way we can:
Thank you for understanding :D
The text was updated successfully, but these errors were encountered: