Skip to content

Commit

Permalink
Fix code & javadoc warnings in the binder package. (#8588)
Browse files Browse the repository at this point in the history
Note: I didn't fix all javadoc warnings mentioned in #8585, since
they're not generated with a modern java version, and the fix feels
worse than the warning.

Specifically, {@link X.Y} generates a warning if only X is imported,
and {@link Z} generates a warning if Z is declared later in the class.

In particular, attempting to fix the first issue by importing X.Y results
in a code-readability warning suggesting I shouldn't do that.
  • Loading branch information
markb74 committed Oct 9, 2021
1 parent bb51bb6 commit 9266174
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
2 changes: 1 addition & 1 deletion binder/src/main/java/io/grpc/binder/SecurityPolicy.java
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
@ExperimentalApi("https://github.com/grpc/grpc-java/issues/8022")
public abstract class SecurityPolicy {

public SecurityPolicy() {}
protected SecurityPolicy() {}

/**
* Decides whether the given Android UID is authorized. (Validity is implementation dependent).
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
* need to call into this class to send a transaction (possibly waiting for the transport to become
* ready).
*
* <p>The split between Outbound & Inbound helps reduce this risk, but not entirely remove it.
* <p>The split between Outbound &amp; Inbound helps reduce this risk, but not entirely remove it.
*
* <p>For this reason, while most state within this class is guarded by this instance, methods
* exposed to individual stream instances need to use atomic or volatile types, since those calls
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
import javax.annotation.Nullable;

/**
* Helper class for reading & writing metadata to parcels.
* Helper class for reading &amp; writing metadata to parcels.
*
* <p>Metadata is written to a parcel as a single int for the number of name/value pairs, followed
* by the following pattern for each pair.
Expand Down
1 change: 1 addition & 0 deletions binder/src/main/java/io/grpc/binder/internal/Outbound.java
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ final void send() throws StatusException {
}

@GuardedBy("this")
@SuppressWarnings("fallthrough")
protected final void sendInternal() throws StatusException {
Parcel parcel = Parcel.obtain();
int flags = 0;
Expand Down

0 comments on commit 9266174

Please sign in to comment.