Publish the new binder package in releases. #8585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
approved these changes
Oct 7, 2021
There was a problem hiding this comment.
I do see some javadoc warnings that should be cleaned up (separate PR is fine).
> Task :grpc-binder:javadocs
grpc-java/binder/src/main/java/io/grpc/binder/internal/BinderTransport.java:129: warning - Tag @link: reference not found: EARLIEST_SUPPORTED_WIRE_FORMAT_VERSION
grpc-java/binder/src/main/java/io/grpc/binder/internal/BinderTransportSecurity.java:66: warning - Tag @link: reference not found: Attributes.Builder
grpc-java/binder/src/main/java/io/grpc/binder/ParcelableUtils.java:40: warning - Tag @link: reference not found: Metadata.Key
grpc-java/binder/src/main/java/io/grpc/binder/ParcelableUtils.java:53: warning - Tag @link: reference not found: Metadata.Key
grpc-java/binder/src/main/java/io/grpc/binder/ParcelableUtils.java:40: warning - Tag @link: reference not found: Metadata.Key
grpc-java/binder/src/main/java/io/grpc/binder/ParcelableUtils.java:53: warning - Tag @link: reference not found: Metadata.Key
grpc-java/binder/src/main/java/io/grpc/binder/ParcelableUtils.java:40: warning - Tag @link: reference not found: Metadata.Key
grpc-java/binder/src/main/java/io/grpc/binder/ParcelableUtils.java:53: warning - Tag @link: reference not found: Metadata.Key
8 warnings
|
Looks like the javadoc is including the internal directory. You probably want something like Lines 49 to 50 in 8ac9a4e |
|
Re: Internal Javadoc, I tried excluding the internal directory, but that causes the whole task to fail (since the sources still depend on the internal package). It's not clear how to exclude the internal package from javadoc generation but not from the source path. |
markb74
added a commit
to markb74/grpc-java
that referenced
this pull request
Oct 8, 2021
Note: I didn't fix all javadoc warnings mentioned in grpc#8585, since they're not generated with a modern java version, and the fix feels worse than the warning. Specifically, {@link X.Y} generates a warning if only X is imported, and {@link Z} generates a warning if Z is declared later in the class. In particular, attempting to fix the first issue by importing X.Y results in a code-readability warning suggesting I shouldn't do that.
|
@markb74, that's what the |
markb74
added a commit
that referenced
this pull request
Oct 9, 2021
Note: I didn't fix all javadoc warnings mentioned in #8585, since they're not generated with a modern java version, and the fix feels worse than the warning. Specifically, {@link X.Y} generates a warning if only X is imported, and {@link Z} generates a warning if Z is declared later in the class. In particular, attempting to fix the first issue by importing X.Y results in a code-readability warning suggesting I shouldn't do that.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.