Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: Apply RetryingNameResolver in ManagedChannelImpl #10371

Merged
merged 2 commits into from
Jul 12, 2023
Merged

core: Apply RetryingNameResolver in ManagedChannelImpl #10371

merged 2 commits into from
Jul 12, 2023

Commits on Jul 12, 2023

  1. core: Apply RetryingNameResolver in ManagedChannelImpl 

    Wrapping the DnsNameResolver in DnsNameResolverProvider can cause
problems to external name resolvers that delegate to a DnsResolver
already wrapped in RetryingNameResolver. ManagedChannelImpl would
end up wrapping these name resolvers again, causing an exception
later from a RetryingNameResolver safeguard that checks for double
wrapping.
    @temawi
    temawi committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    42cace0 View commit details
    Browse the repository at this point in the history

  2. Remove commented out code.

    @temawi
    temawi committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    092ee41 View commit details
    Browse the repository at this point in the history