core: Apply RetryingNameResolver in ManagedChannelImpl #10371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrapping the DnsNameResolver in DnsNameResolverProvider can cause problems to external name resolvers that delegate to a DnsResolver already wrapped in RetryingNameResolver. ManagedChannelImpl would end up wrapping these name resolvers again, causing an exception later from a RetryingNameResolver safeguard that checks for double wrapping.
ejona86
approved these changes
Jul 12, 2023
| GrpcUtil.SHARED_CHANNEL_EXECUTOR, | ||
| Stopwatch.createUnstarted(), | ||
| IS_ANDROID); | ||
| // return new RetryingNameResolver( |
There was a problem hiding this comment.
This is a bit strange. Remove it or add a comment?
There was a problem hiding this comment.
That was an oversight, removed.
temawi
added a commit
to temawi/grpc-java
that referenced
this pull request
Jul 12, 2023
Wrapping the DnsNameResolver in DnsNameResolverProvider can cause problems to external name resolvers that delegate to a DnsResolver already wrapped in RetryingNameResolver. ManagedChannelImpl would end up wrapping these name resolvers again, causing an exception later from a RetryingNameResolver safeguard that checks for double wrapping.
temawi
added a commit
to temawi/grpc-java
that referenced
this pull request
Jul 12, 2023
Wrapping the DnsNameResolver in DnsNameResolverProvider can cause problems to external name resolvers that delegate to a DnsResolver already wrapped in RetryingNameResolver. ManagedChannelImpl would end up wrapping these name resolvers again, causing an exception later from a RetryingNameResolver safeguard that checks for double wrapping.
temawi
added a commit
to temawi/grpc-java
that referenced
this pull request
Jul 12, 2023
Wrapping the DnsNameResolver in DnsNameResolverProvider can cause problems to external name resolvers that delegate to a DnsResolver already wrapped in RetryingNameResolver. ManagedChannelImpl would end up wrapping these name resolvers again, causing an exception later from a RetryingNameResolver safeguard that checks for double wrapping.
temawi
added a commit
to temawi/grpc-java
that referenced
this pull request
Jul 12, 2023
Wrapping the DnsNameResolver in DnsNameResolverProvider can cause problems to external name resolvers that delegate to a DnsResolver already wrapped in RetryingNameResolver. ManagedChannelImpl would end up wrapping these name resolvers again, causing an exception later from a RetryingNameResolver safeguard that checks for double wrapping.
temawi
added a commit
that referenced
this pull request
Jul 12, 2023
Wrapping the DnsNameResolver in DnsNameResolverProvider can cause problems to external name resolvers that delegate to a DnsResolver already wrapped in RetryingNameResolver. ManagedChannelImpl would end up wrapping these name resolvers again, causing an exception later from a RetryingNameResolver safeguard that checks for double wrapping.
temawi
added a commit
that referenced
this pull request
Jul 12, 2023
Wrapping the DnsNameResolver in DnsNameResolverProvider can cause problems to external name resolvers that delegate to a DnsResolver already wrapped in RetryingNameResolver. ManagedChannelImpl would end up wrapping these name resolvers again, causing an exception later from a RetryingNameResolver safeguard that checks for double wrapping.
temawi
added a commit
that referenced
this pull request
Jul 12, 2023
Wrapping the DnsNameResolver in DnsNameResolverProvider can cause problems to external name resolvers that delegate to a DnsResolver already wrapped in RetryingNameResolver. ManagedChannelImpl would end up wrapping these name resolvers again, causing an exception later from a RetryingNameResolver safeguard that checks for double wrapping.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapping the
DnsNameResolverinDnsNameResolverProvidercan cause problems to external name resolvers that delegate to aDnsResolveralready wrapped in aRetryingNameResolver.ManagedChannelImplwould end up wrapping these name resolvers again, causing an exception later from aRetryingNameResolversafeguard that checks for double wrapping.This removes the wrapping logic from
DnsNameResolverProviderand hasManagedChannelImplalways explicitly do it.