Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use same version libraries which gradle uses #3911

Merged
merged 1 commit into from
Jan 5, 2018
Merged

use same version libraries which gradle uses #3911

merged 1 commit into from
Jan 5, 2018

Conversation

jyane
Copy link
Member

@jyane jyane commented Jan 3, 2018

No description provided.

carl-mastrangelo
carl-mastrangelo approved these changes Jan 3, 2018
View reviewed changes
Copy link
Contributor

@carl-mastrangelo carl-mastrangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carl-mastrangelo carl-mastrangelo added this to the 1.10 milestone Jan 3, 2018
@dapengzhang0 dapengzhang0 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jan 4, 2018
@kokoro-team kokoro-team removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jan 4, 2018
@dapengzhang0
Copy link
Member

Thanks!

@dapengzhang0 dapengzhang0 merged commit 5aed252 into grpc:master Jan 5, 2018
@jyane jyane deleted the fix-repo-versions branch January 6, 2018 01:39
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dapengzhang0 dapengzhang0 dapengzhang0 approved these changes

@carl-mastrangelo carl-mastrangelo carl-mastrangelo approved these changes

Assignees
No one assigned
Labels
Type: Dependencies
Projects
None yet
Milestone
1.10
Development

Successfully merging this pull request may close these issues.
4 participants
@jyane @dapengzhang0 @carl-mastrangelo @kokoro-team