Upgrade to protobuf 3.6.1 #5320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangkun83
approved these changes
Feb 5, 2019
For Bazel, we upgrade to protobuf 3.6.1.2 and javalite HEAD to fix incompatibilities in newer Bazel releases. compiler/Dockerfile is unused, so it was removed instead of being updated. protoc no longer includes codegen for nano, so we remain on the older protoc any time nano is used.
ejona86
force-pushed
the
protobuf-3.6.1
branch
from
5b9c97b
to
a16e47e
Compare
|
Windows is failing because Protobuf now requires C++11. We'll have to update to a newer version of VS. |
|
@zhangkun83, PTAL, the changes are each in their own separate commit. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bazel, we upgrade to protobuf 3.6.1.2 and javalite HEAD to fix
incompatibilities in newer Bazel releases.
compiler/Dockerfile is unused, so it was removed instead of being updated.
protoc no longer includes codegen for nano, so we remain on the older protoc
any time nano is used.
Protobuf now requires C++11 when compiling, so windows was swapped to
VC 14.
CC @drigz
Fixes #5310