core,stub: Document grpc performs compression nego on server #5401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -180,6 +180,9 @@ public void setMessageCompression(boolean enabled) { | |||
| * The compressor to use will be looked up in the {@link CompressorRegistry}. Default gRPC | |||
| * servers support the "gzip" compressor. | |||
| * | |||
| * <p>It is safe to call this even if the client does not support the compression format chosen. | |||
There was a problem hiding this comment.
Optional: you might call out that the analogous client side call (CallOptions.withCompression) does not safely negotiate.
|
Added documentation to CallOptions. There was already documentation on AbstractStub. |
ejona86
force-pushed
the
compression-doc
branch
from
4e4ac45
to
f16a82d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @AmiDavidW, as this came up in #5358