grpc-testing and grpc-interop-testing no longer transitively depend on mockito (v1.20.x) #5544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dapengzhang0
changed the title
ejona86
approved these changes
Apr 4, 2019
|
The Kokoro CI prod:grpc/java/v1.20.x/branch/android-interop is now passing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picks of 4052608 and 3325881
grpc-testing and grpc-interop-testing in v1.19.0 and earlier used to transitively depend on mockito 1. Now in v1.20.0, if they transitively depend on mocikito 2, it would be a bigger breaking change to our users than they are not depending on mockito at all. (And in next release (v1.21.0) they are no longer depending on mockito anyway.)
Also fixes #5523 in v1.20.x branch.