Closing stream buffering encoder when inactive #590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ejona86 PTAL @Scottmitch @buchgr you may be interested as well, since I'd like to make the same changes to Netty's encoder. |
This was referenced Jul 1, 2015
| @@ -227,6 +232,8 @@ public void channelInactive(ChannelHandlerContext ctx) throws Exception { | |||
| logger.fine("Network channel is closed"); | |||
| goAwayStatus(goAwayStatus().augmentDescription("Network channel closed")); | |||
| cancelPing(); | |||
| // Close the encoder now to cancel any buffered streams. | |||
| encoder().close(); | |||
There was a problem hiding this comment.
This will cause two calls to close the encoder, one here and one in
an alternative fix is to alter netty to close the encoders before it notifies stream closure to each stream in that method
There was a problem hiding this comment.
Good point. Closing this in favor of fixing in Netty.
|
Closing this ... will be fixed by netty/netty#3961 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.