Proper shutdown of HTTP2 encoder when channelInactive #3961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The problem is described in grpc/grpc-java#605. Basically, when using `StreamBufferingEncoder` there is a chance of creating zombie streams that never get closed. Modifications: Change `Http2ConnectionHandler`'s `channelInactive` handling logic to shutdown the encoder/decoder before shutting down the active streams. Result: Fixes grpc/grpc-java#605
|
@Scottmitch @louiscryan PTAL |
| * Thrown if buffered streams are terminated due to this encoder being closed. | ||
| */ | ||
| public static final class ChannelClosedException extends Http2Exception { | ||
| public ChannelClosedException() { |
|
@nmittler - Just 1 small comment...and fix build failure...then lgtm. |
| @@ -127,6 +139,10 @@ public ChannelFuture writeHeaders(ChannelHandlerContext ctx, int streamId, Http2 | |||
| public ChannelFuture writeHeaders(ChannelHandlerContext ctx, int streamId, Http2Headers headers, | |||
| int streamDependency, short weight, boolean exclusive, | |||
| int padding, boolean endOfStream, ChannelPromise promise) { | |||
| if (closed) { | |||
| promise.setFailure(new ChannelClosedException()); | |||
| return promise; | |||
There was a problem hiding this comment.
merge the two lines... return promise.setFailure(....)
|
@normanmaurer anything else or shall I cherry-pick? |
|
@nmittler - LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The problem is described in grpc/grpc-java#605. Basically, when using
StreamBufferingEncoderthere is a chance of creating zombie streams that never get closed.Modifications:
Change
Http2ConnectionHandler'schannelInactivehandling logic to shutdown the encoder/decoder before shutting down the active streams.Result:
Fixes grpc/grpc-java#605