Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: Remove unnecessary subchannel creation by helper, use mocked subchannels directly #5977

Merged
merged 1 commit into from
Jul 10, 2019
Merged

xds: Remove unnecessary subchannel creation by helper, use mocked subchannels directly #5977

merged 1 commit into from
Jul 10, 2019

Conversation

voidzcy
Copy link
Contributor

@voidzcy voidzcy commented Jul 10, 2019

No description provided.

dapengzhang0
dapengzhang0 approved these changes Jul 10, 2019
View reviewed changes
Copy link
Member

@dapengzhang0 dapengzhang0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up.

@voidzcy voidzcy merged commit ce830bc into grpc:master Jul 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dapengzhang0 dapengzhang0 dapengzhang0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@voidzcy @dapengzhang0