Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comment in MethodDescriptor.Marshaller #941

Merged
merged 1 commit into from
Sep 3, 2015
Merged

Update comment in MethodDescriptor.Marshaller #941

merged 1 commit into from
Sep 3, 2015

Conversation

carl-mastrangelo
Copy link
Contributor

Half-heartedly fixes issue #722

@carl-mastrangelo carl-mastrangelo mentioned this pull request Sep 3, 2015
Closed
@ejona86
Copy link
Member

ejona86 commented Sep 3, 2015

I had a different understanding of the change requested in #722, "Marshaller should use 'deserializing' rather than parsing." I thought that meant instead of:

A typed abstraction over message parsing and serialization.

We would have:

A typed abstraction over message serialization and deserialization.

@carl-mastrangelo
Copy link
Contributor Author

@ejona86 PTAL

@ejona86
Copy link
Member

ejona86 commented Sep 3, 2015

@carl-mastrangelo LGTM

@carl-mastrangelo carl-mastrangelo merged commit f612746 into grpc:master Sep 3, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@ejona86 ejona86

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carl-mastrangelo @ejona86