Add overrideAuthority for Channel construction #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
force-pushed
the
override-authority
branch
from
c6f5a7b
to
a0c348e
Compare
| @@ -64,7 +64,7 @@ | |||
| * The authority of the destination this channel connects to. Typically this is in the format | |||
| * {@code host:port}. | |||
| * | |||
| * @return authority of remote, or {@code null} | |||
| * @return authority of remote | |||
There was a problem hiding this comment.
nit: maybe just remove the @return altogether? It's duplicating the docs.
|
@ejona86 LGTM |
Although the functionality is currently available by passing a manually-created InetAddress, that requires that the user do I/O before calling our API and does not work with naming in the future.
We want to allow overriding authority in the ManagedChannelBuilder for testing. In doing that, we basically require that all Channels support authority. In reality, this simplifies things and is already being done by the C implementation, as their unix domain socket support uses "localhost" just like our in-process transport now does. We can debate some whether "localhost" is really the most appropriate authority for the in-process transport, but that should probably happen later since "localhost" is "good enough" for now.
ejona86
force-pushed
the
override-authority
branch
from
a0c348e
to
bccaf07
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #925