Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add overrideAuthority for Channel construction #997

Merged
merged 4 commits into from
Sep 11, 2015
Merged

Add overrideAuthority for Channel construction #997

merged 4 commits into from
Sep 11, 2015

Commits on Sep 11, 2015

  1. Add overrideAuthority to NettyChannelBuilder 

    Although the functionality is currently available by passing a
manually-created InetAddress, that requires that the user do I/O before
calling our API and does not work with naming in the future.
    @ejona86
    ejona86 committed Sep 11, 2015
    Configuration menu
    Copy the full SHA
    3ae18ea View commit details
    Browse the repository at this point in the history

  2. Add overrideAuthority to OkHttpChannelBuilder

    @ejona86
    ejona86 committed Sep 11, 2015
    Configuration menu
    Copy the full SHA
    de32e29 View commit details
    Browse the repository at this point in the history

  3. Add overrideAuthority to ManagedChannelBuilder 

    We want to allow overriding authority in the ManagedChannelBuilder for
testing. In doing that, we basically require that all Channels support
authority. In reality, this simplifies things and is already being done
by the C implementation, as their unix domain socket support uses
"localhost" just like our in-process transport now does.

We can debate some whether "localhost" is really the most appropriate
authority for the in-process transport, but that should probably happen
later since "localhost" is "good enough" for now.
    @ejona86
    ejona86 committed Sep 11, 2015
    Configuration menu
    Copy the full SHA
    5b2a03a View commit details
    Browse the repository at this point in the history

  4. Use real authority parsing in ClientAuthInterceptor

    @ejona86
    ejona86 committed Sep 11, 2015
    Configuration menu
    Copy the full SHA
    bccaf07 View commit details
    Browse the repository at this point in the history