Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sleep from Observability Interop Test binary now that its done in close() #9977

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Remove sleep from Observability Interop Test binary now that its done in close() #9977

merged 2 commits into from
Mar 22, 2023

Conversation

stanley-cheung
Copy link
Contributor

After #9972, the sleep() is done inside Observability close(), we can remove this sleep() in the Observability Interop test binary.

@ejona86 ejona86 merged commit a6cdf49 into grpc:master Mar 22, 2023
@ejona86 ejona86 added the TODO:backport PR needs to be backported. Removed after backport complete label Mar 22, 2023
ejona86 pushed a commit to ejona86/grpc-java that referenced this pull request Mar 22, 2023
@stanley-cheung @ejona86
Remove sleep from Observability Interop Test binary now that its done…
c00e396 
… in close() (grpc#9977)

After grpc#9972, the `sleep()` is done inside Observability `close()`, we can remove this `sleep()` in the Observability Interop test binary.
@ejona86 ejona86 mentioned this pull request Mar 22, 2023
Merged
@stanley-cheung stanley-cheung deleted the remove-o11y-test-sleep branch March 23, 2023 00:35
ejona86 pushed a commit that referenced this pull request Mar 23, 2023
@stanley-cheung @ejona86
Remove sleep from Observability Interop Test binary now that its done…
61ec299 
… in close() (#9977)

After #9972, the `sleep()` is done inside Observability `close()`, we can remove this `sleep()` in the Observability Interop test binary.
@ejona86 ejona86 removed the TODO:backport PR needs to be backported. Removed after backport complete label Mar 23, 2023
larry-safran pushed a commit to larry-safran/grpc-java that referenced this pull request Mar 23, 2023
@stanley-cheung @larry-safran
Remove sleep from Observability Interop Test binary now that its done…
0f51b9c 
… in close() (grpc#9977)

After grpc#9972, the `sleep()` is done inside Observability `close()`, we can remove this `sleep()` in the Observability Interop test binary.
larry-safran pushed a commit to larry-safran/grpc-java that referenced this pull request Mar 29, 2023
@stanley-cheung @larry-safran
Remove sleep from Observability Interop Test binary now that its done…
21fe4c2 
… in close() (grpc#9977)

After grpc#9972, the `sleep()` is done inside Observability `close()`, we can remove this `sleep()` in the Observability Interop test binary.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stanley-cheung @ejona86