Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sleep from Observability Interop Test binary now that its done in close() #9977

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Remove sleep from Observability Interop Test binary now that its done in close() #9977

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e74180
Remove sleep from Observability Interop Test binary now that its done…
stanley-cheung Mar 21, 2023
1721043
Removed unused import
stanley-cheung Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions ...rvability/interop/src/main/java/io/grpc/gcp/observability/interop/TestServiceInterop.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
import io.grpc.testing.integration.TestServiceClient;
import io.grpc.testing.integration.TestServiceServer;
import java.util.Arrays;
import java.util.concurrent.TimeUnit;

/**
* Combined interop client and server for observability testing.
Expand All @@ -47,11 +46,6 @@ public static void main(String[] args) throws Exception {
} else {
TestServiceServer.main(args);
}
// TODO(stanleycheung): remove this once the observability exporter plugin is able to
// gracefully flush observability data to cloud at shutdown
final int o11yCloseSleepSeconds = 65;
System.out.println("Sleeping " + o11yCloseSleepSeconds + " seconds before exiting");
Thread.sleep(TimeUnit.MILLISECONDS.convert(o11yCloseSleepSeconds, TimeUnit.SECONDS));
}
}

Expand Down