Skip to content

Commit

Permalink
Merge pull request #2717 from murgatroid99/proto-loader_duplicate_met…
Browse files Browse the repository at this point in the history
…hod_declarations

proto-loader: Avoid generating duplicate method declarations in some cases
  • Loading branch information
murgatroid99 committed May 1, 2024
2 parents 5674498 + b292946 commit 5e1ab3e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/proto-loader/bin/proto-loader-gen-types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,7 @@ function generateServiceClientInterface(formatter: TextFormatter, serviceType: P
formatter.indent();
for (const methodName of Object.keys(serviceType.methods).sort()) {
const method = serviceType.methods[methodName];
for (const name of [methodName, camelCase(methodName)]) {
for (const name of new Set([methodName, camelCase(methodName)])) {
if (CLIENT_RESERVED_METHOD_NAMES.has(name)) {
continue;
}
Expand Down

0 comments on commit 5e1ab3e

Please sign in to comment.