Ensure ordering between received messages and status

grpc · Oct 14, 2022 · 63d9f6a · 63d9f6a
1 parent 59a2cbc
commit 63d9f6a
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/packages/grpc-js/src/load-balancing-call.ts b/packages/grpc-js/src/load-balancing-call.ts
@@ -44,6 +44,8 @@ export class LoadBalancingCall implements Call {
   private writeFilterPending = false;
   private pendingMessage: {context: MessageContext, message: Buffer} | null = null;
   private pendingHalfClose = false;
+  private readFilterPending = false;
+  private pendingChildStatus: StatusObject | null = null;
   private ended = false;
   private serviceUrl: string;
   private filterStack: FilterStack;
@@ -153,14 +155,23 @@ export class LoadBalancingCall implements Call {
                   this.listener!.onReceiveMetadata(this.filterStack.receiveMetadata(metadata));
                 },
                 onReceiveMessage: message => {
+                  this.readFilterPending = true;
                   this.filterStack.receiveMessage(message).then(filteredMesssage => {
+                    this.readFilterPending = false;
                     this.listener!.onReceiveMessage(filteredMesssage);
+                    if (this.pendingChildStatus) {
+                      this.outputStatus(this.pendingChildStatus, 'PROCESSED');
+                    }
                   }, (status: StatusObject) => {
                     this.cancelWithStatus(status.code, status.details);
                   });
                 },
                 onReceiveStatus: status => {
-                  this.outputStatus(status, 'PROCESSED');
+                  if (this.readFilterPending) {
+                    this.pendingChildStatus = status;
+                  } else {
+                    this.outputStatus(status, 'PROCESSED');
+                  }
                 }
               });
             } catch (error) {