Address the feedback: making the buildscript flow more transparent

grpc · May 3, 2024 · 9f9f6e7 · 9f9f6e7
1 parent c6391f3
commit 9f9f6e7
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/packages/grpc-js-xds/scripts/psm-interop-test-node.sh b/packages/grpc-js-xds/scripts/psm-interop-test-node.sh
@@ -14,12 +14,13 @@
 # limitations under the License.
 set -eo pipefail
 
-# Constants
+# Input parameters to psm:: methods of the install script.
 readonly GRPC_LANGUAGE="node"
-readonly GITHUB_REPOSITORY_NAME="grpc-node"
-readonly TEST_DRIVER_INSTALL_SCRIPT_URL="https://raw.githubusercontent.com/${TEST_DRIVER_REPO_OWNER:-grpc}/psm-interop/${TEST_DRIVER_BRANCH:-main}/.kokoro/psm_interop_kokoro_lib.sh"
 readonly BUILD_SCRIPT_DIR="$(dirname "$0")"
 
+# Used locally.
+readonly TEST_DRIVER_INSTALL_SCRIPT_URL="https://raw.githubusercontent.com/${TEST_DRIVER_REPO_OWNER:-grpc}/psm-interop/${TEST_DRIVER_BRANCH:-main}/.kokoro/psm_interop_kokoro_lib.sh"
+
 psm::lang::source_install_lib() {
   echo "Sourcing test driver install script from: ${TEST_DRIVER_INSTALL_SCRIPT_URL}"
   local install_lib
@@ -35,4 +36,5 @@ psm::lang::source_install_lib() {
 }
 
 psm::lang::source_install_lib
+source "${BUILD_SCRIPT_DIR}/psm-interop-build-${GRPC_LANGUAGE}.sh"
 psm::run "${PSM_TEST_SUITE}"