fix: add addition check if the provided code is valid gRPC code

grpc · Sep 1, 2020 · aaee068 · aaee068
1 parent 5e42be1
commit aaee068
Showing 1 changed file with 14 additions and 5 deletions.
diff --git a/packages/grpc-js/src/server-call.ts b/packages/grpc-js/src/server-call.ts
@@ -739,15 +739,24 @@ export class Http2ServerCallStream<
       } else {
         this.messagesToPush.push(deserialized);
       }
-    } catch (err) {
+    } catch (error) {
       // Ignore any remaining messages when errors occur.
       this.bufferedMessages.length = 0;
 
-      if(!err.code){
-        err.code = Status.INTERNAL;
+      if (
+        !(
+          'code' in error &&
+          typeof error.code === 'number' &&
+          Number.isInteger(error.code) &&
+          error.code >= Status.OK &&
+          error.code <= Status.UNAUTHENTICATED
+        )
+      ) {
+        // The error code is not a valid gRPC code so its being overwritten.
+        error.code = Status.INTERNAL;
       }
-      
-      readable.emit('error', err);
+
+      readable.emit('error', error);
     }
 
     this.isPushPending = false;