Merge pull request #1556 from slavovojacek/master

fix(grpc-js): Add support for impl type to server.addService
grpc · Sep 2, 2020 · e21f337 · e21f337
2 parents 1178d55 + fba1ee0
commit e21f337
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/packages/grpc-js/src/server.ts b/packages/grpc-js/src/server.ts
@@ -144,9 +144,13 @@ export class Server {
     throw new Error('Not implemented. Use addService() instead');
   }
 
-  addService(
-    service: ServiceDefinition,
-    implementation: UntypedServiceImplementation
+  addService<
+    ImplementationType extends {
+      [key: string]: any
+    }
+  >(
+    service: ServiceDefinition<ImplementationType>,
+    implementation: ImplementationType
   ): void {
     if (this.started === true) {
       throw new Error("Can't add a service to a started server.");

diff --git a/packages/grpc-js/test/test-server.ts b/packages/grpc-js/test/test-server.ts
@@ -181,7 +181,7 @@ describe('Server', () => {
       const server = new Server();
 
       assert.throws(() => {
-        server.addService({}, dummyImpls);
+        server.addService(({} as any), dummyImpls);
       }, /Cannot add an empty service to a server/);
     });