Server#addService - lift the limitation of adding a new service to st…

…arted server
grpc · Oct 29, 2020 · e49524a · e49524a
1 parent afe4c3e
commit e49524a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/packages/grpc-js/src/server.ts b/packages/grpc-js/src/server.ts
@@ -148,10 +148,6 @@ export class Server {
     service: ServiceDefinition,
     implementation: UntypedServiceImplementation
   ): void {
-    if (this.started === true) {
-      throw new Error("Can't add a service to a started server.");
-    }
-
     if (
       service === null ||
       typeof service !== 'object' ||
@@ -637,7 +633,7 @@ async function handleUnary<RequestType, ResponseType>(
   if (request === undefined || call.cancelled) {
     return;
   }
-  
+
   const emitter = new ServerUnaryCallImpl<RequestType, ResponseType>(
     call,
     metadata,

diff --git a/packages/grpc-js/test/test-server.ts b/packages/grpc-js/test/test-server.ts
@@ -202,7 +202,7 @@ describe('Server', () => {
       });
     });
 
-    it('fails if the server has been started', done => {
+    it('succeeds after server has been started', done => {
       const server = new Server();
 
       server.bindAsync(
@@ -211,9 +211,9 @@ describe('Server', () => {
         (err, port) => {
           assert.ifError(err);
           server.start();
-          assert.throws(() => {
+          assert.doesNotThrow(() => {
             server.addService(mathServiceAttrs, dummyImpls);
-          }, /Can't add a service to a started server\./);
+          });
           server.tryShutdown(done);
         }
       );