You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Using the grpc-health-check with Typescript, the package does not currently offer typings, making it cumbersome to work with.
Describe the solution you'd like
Include typings into the package via the tools made available to generate them. As part of the publishing process, my suggestion would be to use ProtobufJS to generate the typings and include them into the published package.
Describe alternatives you've considered
An alternative solution and a current workaround that I implement is compiling the typings in the implementing project. This, however, is not efficient. It requires bundling the Health protocol definition in every implementing project.
Additional context
N/A
The text was updated successfully, but these errors were encountered:
Currently the Protobuf code for that library is generated using grpc-tools, so the types for that would need to be generated with grpc_tools_node_protoc_ts to get the corresponding types. Pull requests are welcome.
Alternatively, for a while I have considered creating a version 2.0 of the library that exports a PackageDefinition object that can be loaded into either gRPC implementation. Generating usable TypeScript types for that might be tricky.
I just created a proposal for a new API for this library that would include this change, at grpc/proposal#391. Please comment there if you have any feedback on that design.
Is your feature request related to a problem? Please describe.
Using the
grpc-health-check
with Typescript, the package does not currently offer typings, making it cumbersome to work with.Describe the solution you'd like
Include typings into the package via the tools made available to generate them. As part of the publishing process, my suggestion would be to use ProtobufJS to generate the typings and include them into the published package.
Describe alternatives you've considered
An alternative solution and a current workaround that I implement is compiling the typings in the implementing project. This, however, is not efficient. It requires bundling the Health protocol definition in every implementing project.
Additional context
N/A
The text was updated successfully, but these errors were encountered: