L106: Node Heath Check Library 2.0 #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 25, 2023
wenbozhu
reviewed
Aug 25, 2023
| [serviceName: string]: ServingStatus; | ||
| } | ||
|
|
||
| class HealthImplementation { |
There was a problem hiding this comment.
Do we need to call out that this is server-only, e.g. ServerHealthImplementation ?
There was a problem hiding this comment.
The current API uses a similar name to refer to an object with similar functionality, and no user that I have seen has expressed any confusion, so I think the name is fine as it is.
wenbozhu
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.