Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calls in GRPC fail when passed options is undefined #178

Closed
connor4312 opened this issue Feb 10, 2018 · 3 comments
Closed

Calls in GRPC fail when passed options is undefined #178

connor4312 opened this issue Feb 10, 2018 · 3 comments
Assignees
@murgatroid99

Comments

@connor4312
Copy link

Changes introduced in #162 cause calls to fail if the call options are undefined, such as in this call. This resulted in significant regressions in many scenarios.
@murgatroid99 murgatroid99 self-assigned this Feb 12, 2018
@murgatroid99
Copy link
Member

Sorry about that. I didn't realize that undefined was accepted before. We'll publish a bug fix soon.

This was referenced Feb 13, 2018
Merged
Merged
@murgatroid99
Copy link
Member

I have published version 1.9.1, which includes a fix for this issue.

@connor4312
Copy link
Author

Thank you!

@lock lock bot locked as resolved and limited conversation to collaborators Sep 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@murgatroid99 murgatroid99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@murgatroid99 @connor4312