Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc version 1.9.0 breaks getAll() #59

Closed
mjhilt opened this issue Feb 10, 2018 · 4 comments
Closed

grpc version 1.9.0 breaks getAll() #59

mjhilt opened this issue Feb 10, 2018 · 4 comments
Assignees
Labels

Comments

@mjhilt
Copy link

mjhilt commented Feb 10, 2018

I don't have a good unit test, but the following sequence throws an error:
etcd.getAll().prefix(myPrefix).strings().then() --> Error: Argument mismatch in makeUnaryRequest

I can dig deeper if needed, but my guess is you just need to fix your dependency for now.

@connor4312 connor4312 added the bug label Feb 10, 2018
@connor4312 connor4312 self-assigned this Feb 10, 2018
@connor4312
Copy link
Member

Thanks for the report, I'll look into it tonight

@acarl005
Copy link

acarl005 commented Feb 10, 2018

Same issue here.

const keys = await etcd.getAll().prefix('stem').strings()
Error: Argument mismatch in makeUnaryRequest
    at ServiceClient.Client.makeUnaryRequest (/Users/andy/Documents/stem/stem-ensemble/node_modules/grpc/src/client.js:528:11)
    at apply (/Users/andy/Documents/stem/stem-ensemble/node_modules/grpc/node_modules/lodash/lodash.js:470:17)
    at ServiceClient.wrapper (/Users/andy/Documents/stem/stem-ensemble/node_modules/grpc/node_modules/lodash/lodash.js:5329:16)
    at Promise (/Users/andy/Documents/stem/stem-ensemble/node_modules/etcd3/lib/src/connection-pool.js:28:23)
    at new Promise (<anonymous>)
    at runServiceCall (/Users/andy/Documents/stem/stem-ensemble/node_modules/etcd3/lib/src/connection-pool.js:27:12)
    at getConnection.then (/Users/andy/Documents/stem/stem-ensemble/node_modules/etcd3/lib/src/connection-pool.js:160:20)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)
    at Function.Module.runMain (module.js:678:11)

@connor4312
Copy link
Member

Looks like this is a result of grpc/grpc-node#162. I'll lock grpc to 1.8.0 in this module and look into PR'ing a fix to grpc in the morning.

@connor4312
Copy link
Member

Fixed in 7a034e6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants