Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deadline causes unnecessary memory usage #2332

Closed
dora-gt opened this issue Jan 21, 2023 · 3 comments
Closed

deadline causes unnecessary memory usage #2332

dora-gt opened this issue Jan 21, 2023 · 3 comments

Comments

@dora-gt
Copy link

dora-gt commented Jan 21, 2023

Problem description

If I specify deadline on calls, it causes unnecessary memory usage like "partial memory leak".
The objects which were created for succeeded calls should be consumed immediately before given "deadline"s.

Reproduction steps

Set deadline like Date.now() + 1000000. Call it so many times. Heap is consumed massively.

Environment

  • OS name, version and architecture: [e.g. Linux Ubuntu 18.04 amd64]
    • macOS
  • Node version [e.g. 8.10.0]
    • v16.15.1
  • Node installation method [e.g. nvm]
    • nvm
  • Package name and version [e.g. gRPC@1.12.0]
    • @grpc/grpc-js@1.7.3
    • @grpc/grpc-js@1.8.4

Additional context

When far deadline is given:
image

When near deadline is given:
image

@murgatroid99
Copy link
Member

I think I fixed this in version 1.8.5. Please try it.

@dora-gt
Copy link
Author

dora-gt commented Jan 24, 2023

Wow thanks! Will report the result.

@dora-gt
Copy link
Author

dora-gt commented Jan 26, 2023

Seems solved, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants