gRPC sporadically doesn't build properly under node 11. #594
Comments
|
This looks like we have a broken source distribution for 1.15.1... |
|
I don't know what's going on with that source distribution. I tried it myself and it works, and that file is present and in the include paths. |
|
Maybe it's a Node 11 thing? Did you try with this runtime? |
|
So I just tried installing |
nicolasnoble
added
requires reporter action
and removed
requires reporter action
labels
|
From grpc/grpc#17011 - there IS something going on, it's sporadic, and horribly feels like a race condition. I don't know where the race is yet, but it's definitely related to node 11, and not with grpc itself. |
|
By the looks of it, there'll be a node 11.0.1 release soon, with issues in there that may be related to this. Please wait until this is released before attempting to use node 11. |
nicolasnoble
changed the title
|
Thanks for investigating, we'll wait and see if things change with node 11.0.1 :) |
|
Works fine with Node 10.12.0 |
Using LTS as Node 11.0.0 breaks gRPC - grpc/grpc-node#594
|
Running Node Seems like this file: |
|
ArchLinux nodejs 11.0 fails EVERY time. But with node 10.13 from nvm it works fine. Here is my failing build log |
gyp ERR! configure error
gyp ERR! stack Error: Command failed: /usr/bin/python -c import sys; print "%s.%s.%s" % sys.version_info[:3];
gyp ERR! stack File "<string>", line 1
gyp ERR! stack import sys; print "%s.%s.%s" % sys.version_info[:3];
gyp ERR! stack ^
gyp ERR! stack SyntaxError: invalid syntax
gyp ERR! stack
gyp ERR! stack at ChildProcess.exithandler (child_process.js:289:12)
gyp ERR! stack at ChildProcess.emit (events.js:182:13)
gyp ERR! stack at maybeClose (internal/child_process.js:962:16)
gyp ERR! stack at Process.ChildProcess._handle.onexit (internal/child_process.js:251:5)... gyp ERR! command "/usr/bin/node" "/usr/bin/node-gyp" "build"
"--fallback-to-build"
"--library=static_library"
"--module=/home/user/grpc-test/node_modules/grpc/src/node/extension_binary/node-v67-linux-x64-glibc/grpc_node.node"
"--module_name=grpc_node"
"--module_path=/home/user/grpc-test/node_modules/grpc/src/node/extension_binary/node-v67-linux-x64-glibc"
"--napi_version=3"
"--node_abi_napi=napi"
gyp ERR! cwd /home/user/grpc-test/node_modules/grpc
gyp ERR! node -v v11.0.0
gyp ERR! node-gyp -v v3.8.0Let's have a look $ python --version
Python 2.7.15Same issue when switching to python3 $ python --version
Python 3.7.1 |
|
The original issue is about sporadic compilation failures under Node 11. If you are experiencing different errors under a different version of Node, please file a separate issue. |
|
same issue here |
|
reproduced using docker node:latest (11.1.0) and travis here. grpc compiles 2 times successfully, then on the third time it fails. The source binaries are not available yet as indicated with "Pre-built binaries not found for grpc@1.13.1 and node@11.1.0" |
|
Found the rootcause. The culprit is mapbox/node-pre-gyp#426. A workaround for now with node 11 is to always add the |
|
@nicolasnoble dude, you're a genius. You saved me from all the frustrations that I was building up due to this issue for the past week! Way to go! |
|
@nicolasnoble what about |
|
We've never officially supported yarn as a distribution system. |
|
I have the same problem running MacOS High Sierra using homebrew to install node and the installed version is 11.0. Build from sources option did not work. |
|
node 10.13 worked. Thanks @nicolasnoble |
|
@Djiit electron-builder is a different issue altogether. Please read the relevant section of our readme about using grpc with electron: https://github.com/grpc/grpc-node/tree/master/packages/grpc-native-core#about-electron |
would you please explain me what does |
why only this fix works, what is the actual issue happening? is it because whenever it goes to download the |
|
I used Note ArchLinux OS |
|
@Tsangares that may be a tangential issue, where we don't properly support your compiler. It's in fact the same as grpc/grpc#15576 - is your compiler gcc 8? If yes, please follow along on the other issue. |
|
@swoodivyesh the explanations are on the various bugs I've filed against Using |
|
Using node 10.13.0 And still getting error anyone else? I tried npm install --build-from-source but that also doesnt work |
|
@spencerfontein please create a new issue with the full report of the failure you are experiencing. |
okay so was it due to |
|
I fix this using a Node version v10.13.0 after I delete node_modules and install with npm install again and works for me. |
|
It fails for me when I try to build from source in node v11: Is it my bad? |
|
Which is a duplicate of grpc/grpc#15576 Please stop trying to use grpc with node 11 until node-pre-gyp has node 11 support. Then we'll be able to properly assist. |
|
Sorry mate.
So this is not applicable then. |
it is! @mantielero that's what resolved it for me. What I understood from this problem that This is totally my understanding so correct me if I'm wrong. |
|
@mantielero your issue is that you can't compile from source because of grpc/grpc#15576 since your compiler isn't agreeing with the code we publish. Once we can have node-pre-gyp's node 11 support, we'll be able to publish node 11 prebuilt binaries and you won't have to compile from source. |
|
I have to downgrade to v10.13.0 of Node, delete my node_modules folder and do npm install... Works for me |
|
The only solution I found was to downgrade Node to the current lts : 10.13.0 Steps:
|
|
I've published grpc 1.16.1, that now depends on node-pre-gyp 0.12.0. Through this update, this issue here should now be fixed, and also, node 11 support is in. |
|
Same problem, i fix him just with sudo... strange i think it was not a permission problem... don t understand |
|
Your issue is most likely unrelated to what was going on here. Please open a new issue with the full report of the failure. |
and others
Problem description
A clear and concise description of what the problem is.
After upgrading to node 11.0.0 npm install fails due to @google-cloud/language dependency which has a dependency to google-gax which has a dependency to grpc@1.15.1
Reproduction steps
Give very precise steps you've discovered to reproduce your problem. If possible and applicable, provide us with a repository we can clone that contains a reproduction case. Also if possible and applicable, please include a Dockerfile that exhibits the problem if it's specific to a certain environment. Bug reports with no reproduction steps will be closed.
Npm install
-Node version 11.0.0
-Add reference to @google-cloud/language
Environment
Additional context
Add any other context about the problem here. If possible, attach full logs. Do not try to omit anything for brevity, but instead include absolutely everything. Please try and set your operating system's locale to English, so that logs contain error messages in the English language.
The text was updated successfully, but these errors were encountered: