Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sub-channels): clear the cleanup interval when all channels are unrefed. #1083

Merged
merged 7 commits into from
Nov 6, 2019
Merged

fix(sub-channels): clear the cleanup interval when all channels are unrefed. #1083

merged 7 commits into from
Nov 6, 2019

Commits on Oct 24, 2019

  1. fix(sub-channels): clear the cleanup interval when all channels are u… 

    …nrefed

Co-authored-by: Natan Sągol <m@merlinnot.com>
    @JrSchild @merlinnot
    JrSchild and merlinnot committed Oct 24, 2019
    Configuration menu
    Copy the full SHA
    20cbfc7 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2019

  1. refactor: simplify if statements

    @JrSchild
    JrSchild committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    93f8169 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2019

  1. fix: cancel the cleanup task inside the unrefUnusedSubchannels function

    @JrSchild
    JrSchild committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    5f271de View commit details
    Browse the repository at this point in the history

  2. fix: correct comments

    @JrSchild
    JrSchild committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    821c9ab View commit details
    Browse the repository at this point in the history

  3. refactor: use null instead of undefined to indicate that cleanupTimer… 

    … is stopped
    @merlinnot
    merlinnot committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    e51a740 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of github.com:grpc/grpc-node into JrSchild/master

    @merlinnot
    merlinnot committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    61d7e77 View commit details
    Browse the repository at this point in the history

  5. fix: correctly initialize cleanupTimer

    @merlinnot
    merlinnot committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    0353dbf View commit details
    Browse the repository at this point in the history