Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of Protobuf.js Message type in TS file #177

Merged
merged 1 commit into from
Feb 9, 2018
Merged

Fix usage of Protobuf.js Message type in TS file #177

merged 1 commit into from
Feb 9, 2018

Conversation

murgatroid99
Copy link
Member

This should fix #176.

kjin
kjin approved these changes Feb 9, 2018
View reviewed changes
Copy link
Contributor

@kjin kjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit -- If the payload has to be an object should it be Message<{}> instead?

@murgatroid99
Copy link
Member Author

murgatroid99 commented Feb 9, 2018 •
edited
Loading

The Message type here is a Protobuf.js type, not a general type for any kind of message that might be transmitted by gRPC, so it's already an object. And honestly, I put any there because I have no idea what that type parameter means, even after reading Protobuf.js's .d.ts file.

@murgatroid99 murgatroid99 merged commit 42a1530 into grpc:v1.9.x Feb 9, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kjin kjin kjin approved these changes

@nicolasnoble nicolasnoble Awaiting requested review from nicolasnoble

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@murgatroid99 @kjin