grpc-js-xds: Log loaded bootstrap info in xDS client (1.4.x) #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murgatroid99
changed the title
lidizheng
reviewed
Sep 20, 2021
| @@ -340,6 +340,7 @@ export class XdsClient { | |||
| if (this.hasShutdown) { | |||
| return; | |||
| } | |||
| trace('Loaded bootstrap info: ' + JSON.stringify(bootstrapInfo, undefined, 2)); | |||
There was a problem hiding this comment.
Is it possible to print the final bootstrap with the build_version, user_agent_name, server_features fields?
There was a problem hiding this comment.
In this code that's not really treated as the "final bootstrap", but I can log the final Node messages that will be sent in the ADS and LRS requests.
There was a problem hiding this comment.
I added logging for those too.
lidizheng
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this to correlate client logs with TD logs. (PR for 1.4.x)