grpc-js-xds: Fix RDS and EDS missing resource handling #1925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes ADS response handling to conform to this section of the Envoy docs. The LDS (Listener) and CDS (Cluster) responses are state-of-the-world, so any resources omitted from any response are considered to be removed. But RDS (Route) and EDS (Endpoint) responses are incremental, so omission of resources does not imply anything about those resources. So, RDS and EDS resources should only be considered to be removed when they are not pointed to by any LDS or CDS resources, respectively. Since we know that we see every LDS and CDS resource in the corresponding responses, we can simply aggregate all of the RDS and EDS names pointed to by those resources in a single response, and consider all others to be removed.
The important changes here are the RDS and EDS changes, to avoid incorrectly marking those resources as removed.
There are no CDS changes in this PR because the CDS handling code already had the correct behavior, similar to what I added in the LDS handling code: https://github.com/grpc/grpc-node/blob/%40grpc/grpc-js%401.4.x/packages/grpc-js-xds/src/xds-stream-state/cds-state.ts#L148-L163