-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document missing options #1983
Document missing options #1983
Conversation
I wrote this in the readme:
But I have to say, I do not know where to find |
I don't see any value in calling out specific options that are not implemented. All of the options not listed are not implemented; there is nothing special about the ones you added the note about. Similarly, I don't think we should call out specific options in the README. We could instead have a general note referencing the list of supported options. |
I wholly disagree. If you are coming from the grpc library, and you read this:
Then you expect everything to be supported. From that moment on, everything unsupported I expect to be listed explicitly. The value in adding this is that for real production use cases (the ones with actual load) there ain't any new unexpected behaviour. This cost us easily 2 hours already (multiple people investigating this in parallel) and multiply that by everyone that is using these options and you have substantial value. |
I think it would be reasonable to migrate the list of supported options from that linked document to the README. However, I don't think it's practical to maintain a list of every option the library doesn't support, and I think it would be misleading to specifically call out only some unsupported options. |
grpc.max_connection_age_grace_ms
grpc.max_connection_age_ms
We were bitten by these missing options. One could argue that it is unclear how to best setup gRPC round robin load balancing in a Kubernetes cluster, but that is besides the point. We were using these options, switched from grpc to grpc-js and suddenly the load was only coming to a few instances, making the service 10x as slow. I'd argue this is missing from the "migration" list in the readme too: https://www.npmjs.com/package/@grpc/grpc-js.