proto-loader: Update to Long 5.x #2110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasnoble
approved these changes
May 2, 2022
|
Note: googleapis/gax-nodejs#1240, googleapis/gax-nodejs#1241. I will pin |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2009, as far as I can tell. The
longpackage exports the type usingexport = Long;which it says is "compatible withimport Long from "long"", but as far as I can tell that is only true if we set the TypeScript option"esModuleInterop": true. Unfortunately, if we were to set that, it appears to generate code that transitively requires all of our users to also set that option to compile any code that depends on@grpc/proto-loader. The alternative is to use theimport =syntax, which seems to work no matter how that option is set.