Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-js: Add null check in pick_first array access #2539

Conversation

murgatroid99
Copy link
Member

This addresses a possible cause of #2537. TypeScript doesn't require this check because the type system does not account for array out-of-bounds access.

@murgatroid99 murgatroid99 merged commit 99ae020 into grpc:@grpc/grpc-js@1.9.x Aug 8, 2023
3 of 5 checks passed
@svenefftinge
Copy link

Thank you! That will fix the problem 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants