Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing zdefs. #255

Merged
merged 1 commit into from
Apr 5, 2018
Merged

Removing zdefs. #255

merged 1 commit into from
Apr 5, 2018

Conversation

nicolasnoble
Copy link
Member

Fixes #254.

@murgatroid99
Copy link
Member

Also probably fixes #136.

@nicolasnoble nicolasnoble changed the title Fixing zdefs. Removing zdefs. Apr 4, 2018
@murgatroid99
Copy link
Member

OK, the Mac Test job passed in this run, and the Mac Build job passed in the previous run, and neither failure was an actual test failure, so I think this is OK to merge.

@murgatroid99 murgatroid99 merged commit 0290422 into grpc:master Apr 5, 2018
@jaimecbernardo jaimecbernardo mentioned this pull request Jul 4, 2018
Open
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@murgatroid99 murgatroid99 murgatroid99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nicolasnoble @murgatroid99 @kokoro-team