Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-js: Fix method config name handling in service configs #2550

Conversation

murgatroid99
Copy link
Member

Issue #2549 made me realize that the code that handles method config names doesn't match the specification in service_config.proto, so this fixes that. There are two related changes here:

  1. The service config parser now accepts a method config name with an unset service field, and coalesces empty string to unset for both the service and method fields.
  2. The code for selecting a method config by name now prioritizes the most specifically matching config, instead of the first one in the list that matches at all.

@murgatroid99 murgatroid99 merged commit 7ca0af6 into grpc:@grpc/grpc-js@1.9.x Aug 22, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants