grpc-js: Propagate connectivity error information to request errors #2598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murgatroid99
force-pushed
the
grpc-js_show_connectivity_errors
branch
from
da072f2
to
3a9f4d2
Compare
gnossen
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, propagate error information from transport code to subchannel connectivity state updates, and from there to pickers returned by pick_first and round_robin. This will help debug connectivity errors, particularly in cases when the request errors do not occur close to the connection attempts in the logs.
The change to the
UnavailablePickerconstructor to accept partial status objects is copied from master.This change does not cover xDS code.