Fix issue #2631 [@grpc/grpc-reflection] Issue with proto file dependencies only on second or next request

[gawsoftpl]

I found issue:

More info about issue #2631

    
    # Correct:
    const toVisit: IFileDescriptorProto[] = [...(this.fileDependencies.get(file) || [])];
    
    # was 
    # const toVisit: IFileDescriptorProto[] = this.fileDependencies.get(file) || [];
    
    while (toVisit.length > 0) {
      # Here loop get item and remove from array but if you 
      # dont spreed fileDendepencies, all depedencies will be removed from original array
      const current = toVisit.pop();

      if (!current || visited.has(current)) {
        continue;
      }

      visited.add(current);
      toVisit.push(...this.fileDependencies.get(current)?.filter((dep) => !visited.has(dep)) || []);
    }

    return Array.from(visited);
  }

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: gawsoftpl / name: Gawsoft (3f2217e)

[gawsoftpl]

Hi @jtimmons can you review this?

[murgatroid99]

Thank you for the fix.

[gawsoftpl]

@murgatroid99 @jtimmons Do you plan create new release for @grpc/reflection 1.0.1 with this fix? Without this server with @grpc/reflection is broken.

[murgatroid99]

I merged the PR 5 minutes ago. Just have some patience and the release will go out in a reasonable amount of time.

[murgatroid99]

This change has been published in @grpc/reflection 1.0.1