Update lodash version to ^4.17.5 (#330) #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
|
Updated CLA |
|
Looks like our test results went private again. I'll have to update this. |
|
It looks like the tests are failing because |
This should resolve warnings related to https://nodesecurity.io/advisories/577
|
@murgatroid99 Got it, sorry, totally missed that it was @types/lodash. I'll update it to latest, but can also just not update that one if you'd prefer. |
|
No worries at all, thanks for doing this. |
nicolasnoble
approved these changes
May 11, 2018
|
This LGTM now; @murgatroid99 ? |
|
Fixes #330. |
murgatroid99
approved these changes
May 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve warnings related to https://nodesecurity.io/advisories/577
Let me know if it shouldn't be updated in all of these places.