Add compression handling to grpc-js #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let toRead: number; | ||
| while (readHead < data.length) { | ||
| switch (this.readState) { | ||
| case ReadState.NO_DATA: | ||
| this.readCompressFlag = (data.readUInt8(readHead) !== 0); | ||
| this.readCompressFlag = data.slice(readHead, readHead+1); |
There was a problem hiding this comment.
Very minor nit: not sure this is passing linter properly due to the +1 with no spaces around it.
nicolasnoble
approved these changes
May 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes all of the existing tests, but I haven't added new ones. This mirrors the existing library, which also doesn't have substantial compression test coverage. In a future PR I will add the applicable compression interop tests.