Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add original name aliases for generated client methods #42

Merged
merged 1 commit into from
Sep 19, 2017
Merged

Add original name aliases for generated client methods #42

merged 1 commit into from
Sep 19, 2017

Conversation

murgatroid99
Copy link
Member

This fixes grpc/grpc#12135

kjin
kjin approved these changes Sep 19, 2017
View reviewed changes
Copy link
Contributor

@kjin kjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@murgatroid99 murgatroid99 merged commit 296897f into grpc:master Sep 19, 2017
@konsumer konsumer mentioned this pull request Sep 20, 2017
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kjin kjin kjin approved these changes

@nicolasnoble nicolasnoble Awaiting requested review from nicolasnoble

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nodejs client doesn't seem to work with include path, anymore
2 participants
@murgatroid99 @kjin