Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly create slices from utf8 strings. #428

Merged
merged 1 commit into from
Jul 10, 2018
Merged

Properly create slices from utf8 strings. #428

merged 1 commit into from
Jul 10, 2018

Conversation

nicolasnoble
Copy link
Member

Fixes #426.

@nicolasnoble nicolasnoble force-pushed the utf8-details branch 3 times, most recently from 77aa7cf to 3612a0e Compare July 9, 2018 20:18
@bysir-zl
Copy link

good job, thank you.

@nicolasnoble nicolasnoble merged commit 1ca2555 into grpc:master Jul 10, 2018
murgatroid99 added a commit that referenced this pull request Jul 11, 2018
@murgatroid99
Merge pull request #432 from nicolasnoble/backport-428
2bfee58 
Backporting #428
@murgatroid99 murgatroid99 mentioned this pull request Jul 23, 2018
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Oct 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@murgatroid99 murgatroid99 murgatroid99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nicolasnoble @bysir-zl @murgatroid99 @kokoro-team