service config: update xDS LB policy configs for gRFC A74 #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
approved these changes
Dec 21, 2023
Comment on lines
417
to
419
| // Configuration for xds_cluster_resolver LB policy. | ||
| // Deprecated. | ||
| message XdsClusterResolverLoadBalancingPolicyConfig { |
There was a problem hiding this comment.
Optional: It might be nice to move these deprecated proto messages to another file so they don't clutter up the non-deprecated ones. E.g. deprecated.proto?
There was a problem hiding this comment.
I've moved the deprecated messages to a separate section at the end of the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See grpc/proposal#404.