Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A74: xDS Config Tears #404

Merged
merged 15 commits into from Feb 16, 2024
Merged

A74: xDS Config Tears #404

merged 15 commits into from Feb 16, 2024

Conversation

markdroth
Copy link
Member

No description provided.

Copy link
Member

@murgatroid99 murgatroid99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than my one comment, this looks reasonable to me.

A74-xds-config-tears.md Outdated Show resolved Hide resolved
A74-xds-config-tears.md Outdated Show resolved Hide resolved
A74-xds-config-tears.md Outdated Show resolved Hide resolved
A74-xds-config-tears.md Outdated Show resolved Hide resolved
A74-xds-config-tears.md Outdated Show resolved Hide resolved
A74-xds-config-tears.md Outdated Show resolved Hide resolved
A74-xds-config-tears.md Outdated Show resolved Hide resolved
A74-xds-config-tears.md Outdated Show resolved Hide resolved
Copy link
Member Author

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review! Please let me know if you have any questions.

A74-xds-config-tears.md Outdated Show resolved Hide resolved
A74-xds-config-tears.md Outdated Show resolved Hide resolved
A74-xds-config-tears.md Outdated Show resolved Hide resolved
A74-xds-config-tears.md Outdated Show resolved Hide resolved
A74-xds-config-tears.md Outdated Show resolved Hide resolved
A74-xds-config-tears.md Outdated Show resolved Hide resolved
A74-xds-config-tears.md Outdated Show resolved Hide resolved
A74-xds-config-tears.md Outdated Show resolved Hide resolved
A74-xds-config-tears.md Outdated Show resolved Hide resolved
copybara-service bot pushed a commit to grpc/grpc that referenced this pull request Jan 2, 2024
Implements gRFC A74 (grpc/proposal#404).

Closes #35011

COPYBARA_INTEGRATE_REVIEW=#35011 from markdroth:xds_watchers_in_xds_resolver a39f71f
PiperOrigin-RevId: 595134549
@markdroth markdroth mentioned this pull request Jan 3, 2024
A74-xds-config-tears.md Outdated Show resolved Hide resolved
A74-xds-config-tears.md Outdated Show resolved Hide resolved
A74-xds-config-tears.md Show resolved Hide resolved
@markdroth markdroth merged commit 9240c4b into grpc:master Feb 16, 2024
1 check passed
@markdroth markdroth deleted the xds_config_tears branch February 16, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants