Expose more http/2 configuration knobs #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Having more control over the configuration of the http/2 layer is useful for certain performance sensitive situations. We recently exposed the max frame size setting on the server (grpc#1253); we should do the same on the client. Modifications: - Add configuration for the max frame size to the client - Fix the clamping of the max frame size on the server (this was missed when reviewing grpc#1253) - Add tests to validate that the configured values are correctly clamped - Send `SETTINGS_INITIAL_WINDOW_SIZE` in the initial SETTINGS frame set to the value of the target window size. Result: Users have more control over HTTP/2 settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Having more control over the configuration of the http/2 layer is useful
for certain performance sensitive situations. We recently exposed the
max frame size setting on the server (#1253); we should do the same on
the client.
Modifications:
when reviewing New configuration parameter for HTTP2 maxFrameSize. #1253)
SETTINGS_INITIAL_WINDOW_SIZEin the initial SETTINGS frame set to thevalue of the target window size.
Result:
Users have more control over HTTP/2 settings.