Cache swift-format #1887
Merged
Cache swift-format #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The CI takes ~7 minutes to run, the longest job is the formatting check which spends most of its time compiling swift-format. Modifications: - Cache the swift-format build directory Result: Faster CI
glbrntt
force-pushed
the
cache-swift-format
branch
from
8683fe1
to
1dda9f5
Compare
glbrntt
added
v2
glbrntt
commented
May 23, 2024
Comment on lines
+105
to
+108
| ! -path './FuzzTesting/.build/*' \ | ||
| ! -path './Performance/QPSBenchmark/.build/*' \ | ||
| ! -path './Performance/Benchmarks/.build/*' \ | ||
| ! -path './scripts/.swift-format-source/*' \ |
There was a problem hiding this comment.
This is now necessary because the soundness check first runs the license check and then would check out and build swift-format, meaning that it'd check the headers of swift-format. This wasn't an issue because of the ordering.
gjcairo
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The CI takes ~7 minutes to run, the longest job is the formatting check which spends most of its time compiling swift-format.
Modifications:
Result:
Faster CI